Visual downwards move with big count goes to end of line and new configuration options #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The lose of one column issue with 'virtualedit' wasn't related with the longest line as previously thought, but with the first line (smallest one) of selection, so changing it fixes now for real (hopefully) the bug of losing one column after moving. Using "range" in functions that didn't used visual selection was a problem when (a:firstline + count) greater than the last line so that range was deleted and replaced with <C-u> at the function calls. The name 'are_same_line' was really referring to a column, so it was renamed after 'are_same_cols' Create function to initialize configurations variables to its defaults.
The variable g:move_map_key can also be a dictionary to permit enabling/disabling of parts of the default mappings using the entries 'vertical' and 'horizontal' and its subentries 'normal' and 'visual'.
matze
requested changes
Aug 23, 2018
plugin/move.vim
Outdated
| @@ -79,6 +88,8 @@ function! s:MoveBlockLeft() range | |||
| let l:distance = v:count ? v:count : 1 | |||
| let l:min_col = min([col("'<"), col("'>")]) | |||
|
|
|||
| " Having 'virtualenv' set to 'onemore' fixes problem of one more movement | |||
There was a problem hiding this comment.
Someone seems to write a lot of Python code as well ;-)
There was a problem hiding this comment.
I still don't find a way to avoid inserting trailing spaces after a left/right move. But found that just removing the spaces after those operations is a possible solution. It is not exactly the same as not inserting them, because removing after an operation can also delete existing (possible wanted) spaces but this solution still will do right most times and could be configurable for those who don't want it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lose of one column issue with 'virtualedit' wasn't related with the
longest line as previously thought, but with the first line (smallest
one) of selection, so changing it fixes now for real (hopefully) the bug
of losing one column after moving.
Using "range" in functions that didn't used visual selection was a
problem when (a:firstline + count) greater than the last line so that
range was deleted and replaced with at the function calls.
The name 'are_same_line' was really referring to a column, so it was
renamed after 'are_same_cols'
Create function to initialize configurations variables to its defaults.
The variable g:move_map_key can also be a dictionary to permit
enabling/disabling of parts of the default mappings using the entries
'vertical' and 'horizontal' and its subentries 'normal' and 'visual'.